Update database.yml.sample: add separate test db#3521
Open
aaronskiba wants to merge 2 commits intodevelopmentfrom
Open
Update database.yml.sample: add separate test db#3521aaronskiba wants to merge 2 commits intodevelopmentfrom
database.yml.sample: add separate test db#3521aaronskiba wants to merge 2 commits intodevelopmentfrom
Conversation
Prior to this change, `config/database.yml` was configured such that running tests would be executed against the dev db. This would result in the dev db being destroyed after tests. This change ensures that the tests are executed against a separate test db and that the dev db persists while testing.
aaronskiba
force-pushed
the
aaron/add-test-db-to-database-config
branch
from
c70f8f7 to
82384fc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3396
Changes proposed in this PR:
config/database.ymlwas configured such that running tests would be executed against the dev db. This would result in the dev db being destroyed after tests. This change ensures that the tests are executed against a separate test db and that the dev db persists while testing.config/database.ymlis set via thecp 'config/database.yml.sample', 'config/database.yml'step whenbin/setup postgresqlis executed.